-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #24547 merge into master: [NativeFS] Update some tests to getFooHandle. -
git.io/JJmrP
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24496 by chromium-wpt-export-bot into master: WebXR - anchors - add WPTs for more complete coverage of the API -
git.io/JJtDO
-
BitBot
(wpt) [PR] servo-wpt-sync requested #24548 merge into master: Make XRSession.inputSources iterable -
git.io/JJmoW
-
BitBot
(wpt) [PR] autofoolip requested #24549 merge into master: Update interfaces/native-file-system.idl -
git.io/JJmol
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #24550 merge into master: Re-add paint_invalidation_container in PrePaintTreeWalk. -
git.io/JJmoE
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #24551 merge into master: [Gecko
Bug 1648839] Evaluate changes in all media queries, then fire change events. -
git.io/JJmKs
-
BitBot
(wpt) [PR] stephenmcgruer closed #24549 by stephenmcgruer: Update interfaces/native-file-system.idl -
git.io/JJmol
-
BitBot
(wpt) [PR] stephenmcgruer reopened #24549 by stephenmcgruer: Update interfaces/native-file-system.idl -
git.io/JJmol
-
BitBot
(wpt) [PR] stephenmcgruer merged #24549 by stephenmcgruer into master: Update interfaces/native-file-system.idl -
git.io/JJmol
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #24552 merge into master: [COOP report] Add support for report-only. -
git.io/JJm6s
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24543 by chromium-wpt-export-bot into master: [NativeFS] Add kind enum to replace isFile/isDirectory. -
git.io/JJmwJ
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24550 by chromium-wpt-export-bot into master: Re-add paint_invalidation_container in PrePaintTreeWalk. -
git.io/JJmoE
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24547 by chromium-wpt-export-bot into master: [NativeFS] Update some tests to getFooHandle. -
git.io/JJmrP
-
BitBot
(wpt) [PR] felipeerias requested #24553 merge into master: First functional tests for scrollbar-gutter -
git.io/JJmMz
-
BitBot
(wpt) [PR] felipeerias closed #24553 by felipeerias: First functional tests for scrollbar-gutter -
git.io/JJmMz
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24527 by chromium-wpt-export-bot into master: [FlexNG] Fix % max-height definiteness -
git.io/JJqFg
-
BitBot
(wpt) [PR] felipeerias requested #24554 merge into master: First functional tests for `scrollbar-gutter` -
git.io/JJmDB
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #24555 merge into master: NEL report for subresource sxg header integrity mismatch -
git.io/JJmSb
-
BitBot
(wpt) [PR] moz-wptsync-bot merged #24551 by moz-wptsync-bot into master: [Gecko
Bug 1648839] Evaluate changes in all media queries, then fire change events. -
git.io/JJmKs
-
BitBot
(wpt) [PR] moz-wptsync-bot merged #24545 by moz-wptsync-bot into master: [Gecko
Bug 1651731] [lint] Python and shell files without `#!` should not be executable -
git.io/JJmwX
-
BitBot
(wpt) [PR] stephenmcgruer closed #24193 by stephenmcgruer: Add interfaces/intervention-reporting.idl -
git.io/Jfdsc
-
BitBot
(wpt) [PR] stephenmcgruer merged #24202 by stephenmcgruer into master: Add interfaces/intervention-reporting.idl and test -
git.io/JfduI
-
BitBot
(wpt) [PR] jdm merged #24409 by jdm into master: Python 3: port webappapis and cross-origin tests in html -
git.io/JJJ1Q
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24454 by chromium-wpt-export-bot into master: Construct StyleResolver in StyleEngine constructor. -
git.io/JJLUZ
-
BitBot
(wpt) [PR] servo-wpt-sync merged #24548 by servo-wpt-sync into master: Make XRSession.inputSources iterable -
git.io/JJmoW
-
jgraham
Apropos nothing in particular I did a quick check on the perf of the manifest as CBOR using cbor2 vs json. The file size is about half, but the load time seems to be nearly the same. CBOR seems to write much faster, although seeing the benefit requires me to drop the (unnecessary?) copy of the data structures we are doing when writing (I think this is safe because we drop the dict once it's written and
-
jgraham
don't mutate the manifest in the interim)
-
jgraham
(this all requires py3, otherwise the CBOR lib is pure python which erases any wins)
-
smcgruer_[EST]
TIL about CBOR
-
smcgruer_[EST]
Standardized messagepack, huh
-
smcgruer_[EST]
I feel company-obliged to mention protobuf :p (I jest!)
-
BitBot
(wpt) [PR] stephenmcgruer requested #24556 merge into master: [WIP] Make lint spit out GitHub CheckRun output file -
git.io/JJmpy
-
jgraham
Well the advantage of CBOR is it's schemaless so it's a drop-in replacement
-
jgraham
well schemaless and a JSON superset in terms of data model
-
smcgruer_[EST]
In that it has a data model? :D
-
smcgruer_[EST]
But yeah, sounds cool... once we get py3
-
jgraham
Certainly I'd expect to do better with one of the N binary formats that requires upfront schemas
-
jgraham
Yeah, this was "my real job is fixing a broken docker image so how can I procrastinate" rather than a serious attempt to add the feature
-
smcgruer_[EST]
Oof, yeo
-
smcgruer_[EST]
*yep
-
jgraham
(people were discussing artifact storage and I was thinking about cases where gecko is using JSON because no one thought about it rather than because it's good, and I was taken to try the experiment)
-
smcgruer_[EST]
Its ok, I'm just sinking further into the pagination sinkhole. My first attempt at handling the paginated github APIs in wpt.fyi had an off-by-one-error -_-
-
smcgruer_[EST]
I swear, I'm an experienced engineer
-
smcgruer_[EST]
Who works on testing infrastructure
-
smcgruer_[EST]
... I should write more tests.
-
jdm
jgraham: any suggestions for what I can look into next for given
servo/servo #27223#issuecomment-656433950 ?
-
jgraham
jdm: Hmm, the testss_root of / seems suspicious
-
jgraham
jdm: LoadManifest in sync.py doens't seem to be passing in the tests_root
-
jgraham
smcgruer_[EST]: Yeah, it wasn't a serious review, just commented since I was looking at it. And I was looking at it because I'm so excited to see that land :)
-
smcgruer_[EST]
Sadly I think its not going to be that easy for lint; I suspect the output might be hard to read not wrapped in a code-block in markdown
-
smcgruer_[EST]
But hey, I've already found one Taskcluster bug :D
-
jgraham
Heh
-
jgraham
The stability jobs are nearly producing the right format since they were previously having their output written to a comment; that might be a simpler place to start from that point of view
-
smcgruer_[EST]
And probably similar importance too, its what most failing-Chromium exports hit. I foolishly thought lint would be easy :)
-
jgraham
Getting good human-readable output is a surprisingly hard problem!
-
jgraham
I hope eventually for some of the jobs we can have some process that picks out the log lines that look like errors and just presents those rather than the whole log
-
jgraham
Notably for all the pytest stuff; the actual test runnign benefits from something more custom
-
BitBot
(wpt) [PR] Hexcles merged #24540 by Hexcles into master: Cleanup newline-removal in manifest_build.py -
git.io/JJmzl
-
smcgruer_[EST]
100%, I think we want to do much better than just dump the logs
-
smcgruer_[EST]
-
jgraham
Ooh, that's not too bad
-
jgraham
I mean it's too verbose, but not totally unreadable or anything
-
Hexcles
woohoo!
-
Hexcles
yet another unplanned power outage (sad)
-
Hexcles
I was going to push smcgruer's fix to prod
-
Hexcles
although arguably I should really try a daily run this time...
-
Hexcles
I'm going to investigate the failures in python unit tests on Azure
-
smcgruer_[EST]
yeah I suggest we leave it in staging till epochs/daily runs
-
Hexcles
They have been training me into force-merging and hence missing real failures
-
smcgruer_[EST]
Thanks, I've been hoping to look at those but havent found hte time
-
jgraham
You shouldn't need to force-merge for those (but maybe you mean for the chromium sync, which I suppose could be checking for all green, rather than just required green)
-
Hexcles
Oh you're absolutely right... I was confused yesterday
-
Hexcles
regardless, training people to ignore errors isn't great
-
jgraham
Agreed; it's easy to assume that any azure failure is unimportant when it could also be real breakage on non-Linux
-
BitBot
(wpt) [PR] Hexcles requested #24557 merge into master: [lint] Fix a type annotation -
git.io/JJYe8
-
Hexcles
(it's a draft right now as I intend to fix the Azure failures together in this PR)
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #24558 merge into master: [PTZ] Add toJSON() to MediaSettingsRange -
git.io/JJYeB
-
BitBot
(wpt) [PR] Hexcles merged #23727 by Hexcles into master: Clipboard API: Implement clipboard-read and clipboard-write Feature Policy. -
git.io/JfgA5
-
BitBot
(wpt) [PR] servo-wpt-sync requested #24559 merge into master: Add missing test path for manifest during WPT syncing. -
git.io/JJYvt
-
jdm
jgraham: thanks for the tip on the manifest.
servo/servo #27230 fixes the issue for me locally, so I'd like your eyes on it.
-
BitBot
(wpt) [PR] stephenmcgruer requested #24560 merge into master: Fix wpt rev-list failure-handling in epochs_update.sh -
git.io/JJYvG
-
smcgruer_[EST]
Urgh, why does the Linux on pixelbook have such old packages -_-
-
smcgruer_[EST]
git 2.11.0 ...
-
smcgruer_[EST]
That was release in Nov 2016 -_-
-
jgraham
Do you also have to fire up the boiler several hours before you build up enough steam for it to boot? :p
-
smcgruer_[EST]
Lol
-
smcgruer_[EST]
I can't even easily update it, it relies on a bunch more packages at newer versions than the ChromeOS Linux subsystem has
-
jgraham
So you'd acutualy be better off if you were running WSL?
-
Hexcles
smcgruer_[EST]: can you nest a Docker inside Linux in ChromeOS?
-
smcgruer_[EST]
... I mean, yes.
-
Hexcles
`datetime.datetime.strptime(reference, '%Y-%m-%dT%H:%M:%S.%fZ')` throws a KeyError on Windows
-
Hexcles
KeyError: '_strptime'
-
Hexcles
-
Hexcles
feel like taking a crazy pill...
-
Hexcles
hopefully I'm not looking at a bug in python stdlib?
-
jdm
jgraham: I followed your suggestion and did the load+update->load_and_update transformation
-
smcgruer_[EST]
-
Hexcles
yeah but that seems very wrong...
-
Hexcles
I mean `import _strptime`
-
Hexcles
-
Hexcles
Python 3 reduced the number of maximum headers allowed in http.server to 100
-
Hexcles
which does not (AFAIK) violate any spec
-
Hexcles
but we have stress tests in WPT with 256 headers which are now broken in py3
-
smcgruer_[EST]
I don't suppose we can just reach in and change the constant?
-
smcgruer_[EST]
Total hack, buttttt
-
BitBot
(wpt) [issue] Hexcles opened #24561: test_verify_taskcluster_yml fails on Windows in Python 3 -
git.io/JJYfV
-
BitBot
(wpt) [PR] ziransun requested #24562 merge into master: Python 3: port tests in webdriver -
git.io/JJYJj
-
jgraham
We should either change the constant or stop using the stdlib here, that's just not a limitation we can have
-
BitBot
(wpt) [PR] autofoolip requested #24563 merge into master: Update interfaces/image-capture.idl -
git.io/JJYLW
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24252 by chromium-wpt-export-bot into master: [scroll-animations] Integrate @scroll-timeline with animations -
git.io/JfbkJ
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24541 by chromium-wpt-export-bot into master: Add some basic Oscillator tests -
git.io/JJmaS
-
BitBot
(wpt) [PR] Hexcles merged #24557 by Hexcles into master: Fix tools/ unit tests -
git.io/JJYe8
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #24564 merge into master: [Gecko
Bug 1582569] part2 : modify tests. -
git.io/JJYqv
-
BitBot
(wpt) [PR] domenic requested #24565 merge into master: Rename some manual dynamic import tests -
git.io/JJYqX
-
BitBot
(wpt) [PR] stephenmcgruer closed #24560 by stephenmcgruer: Fix wpt rev-list failure-handling in epochs_update.sh -
git.io/JJYvG
-
BitBot
(wpt) [PR] stephenmcgruer reopened #24560 by stephenmcgruer: Fix wpt rev-list failure-handling in epochs_update.sh -
git.io/JJYvG
-
Domenic
How would I use step_wait to test that an event is never fired?
-
smcgruer_[EST]
-
Domenic
I want *zero* events though...
-
Domenic
Maybe I'll just go back to step_timeout and someone can correct me on review
-
BitBot
(wpt) [PR] domenic requested #24566 merge into master: Test that MessagePort owners are current, not incumbent -
git.io/JJYmP
-
BitBot
(wpt) [PR] jdm merged #24559 by jdm into master: Add missing test path for manifest during WPT syncing. -
git.io/JJYvt
-
smcgruer_[EST]
Right, at which point the only way the test can verify that is via timeout. Unless there's some other event (or condition) after which you are satisfied that the event could definitely not happen.
-
smcgruer_[EST]
But otherwise, what happens if the browser fires your bad event 10s later?
-
smcgruer_[EST]
Although maybe we could have a way to say "this event shouldn't fire, and if the test reaches the timeout without that happening this test passes"
-
smcgruer_[EST]
jgraham: gsnedders thoughts on ^ ? (Maybe there already is a way I'm forgetting?)
-
jgraham
There isn't a better way. "this thing that can happen an unbounded amount of time in the future should in fact never happen" is strictly impossible to test
-
jgraham
But of course practically we often just add a time limit
-
smcgruer_[EST]
Right, the only thing we could do as infra writers that test authors can't do, is we know when a test has timed out and so could provide a hook to say "thats actually a pass for this test".
-
smcgruer_[EST]
Whereas test authors have to guess how long they can set_timeout that will make it likely that the browser won't ever fire the event, but not too long such that they get a failing (or flaky failing!) TIMEOUT result on some browser/CI
-
BitBot
(wpt) [PR] domenic merged #24565 by domenic into master: Rename some manual dynamic import tests -
git.io/JJYqX
-
BitBot
(wpt) [PR] Hexcles requested #24567 merge into master: [tools] Fix some deprecation warnings -
git.io/JJYYM
-
BitBot
(wpt) [PR] domenic requested #24568 merge into master: Test that BroadcastChannel settings object is current, not incumbent -
git.io/JJYOt
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #24569 merge into master: Remove redundant XrInputSourceArray iterable test -
git.io/JJY3B
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #24096 by chromium-wpt-export-bot into master: Report device pixel content box for SVG elements correctly -
git.io/JfSHa