-
BitBot
(wpt) [PR] autofoolip requested #25556 merge into master: Update interfaces/compression.idl -
git.io/JUBBU
-
BitBot
(wpt) [PR] autofoolip requested #25557 merge into master: Update interfaces/webxr-hand-input.idl -
git.io/JUBBT
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25538 by chromium-wpt-export-bot into master: [WPT] Refactor credential-management to use test-only-api.js -
git.io/JU4j8
-
BitBot
(wpt) [PR] marcoscaceres requested #25558 merge into master: Check removal of allowPaymentRequest IDL attribute -
git.io/JUBB3
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25554 by chromium-wpt-export-bot into master: Deny ElementInternals.shadowRoot for pre-created shadow roots -
git.io/JUBle
-
BitBot
(wpt) [PR] marcoscaceres requested #25559 merge into master: allowpaymentrequest was deprecated -
git.io/JUBu7
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25528 by chromium-wpt-export-bot into master: Add test case for 3D Preserve with 3D Transform Operations -
git.io/JU4KA
-
BitBot
(wpt) [PR] marcoscaceres requested #25560 merge into master: Replace allowpaymentrequest attr with allow=payment -
git.io/JUBz2
-
BitBot
(wpt) [PR] foolip merged #25557 by foolip into master: Update interfaces/webxr-hand-input.idl -
git.io/JUBBT
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25545 by chromium-wpt-export-bot into master: [mathml] Disable multicol for MathML layout -
git.io/JUBkW
-
BitBot
(wpt) [PR] youennf requested #25561 merge into master: WebKit export of
bugs.webkit.org/show_bug.cgi?id=216266 -
git.io/JUBrp
-
jgraham
smcgruer_[EST]: It doesn't work because all the communication with wptrunner has to be via the webdriver-controlled test document
-
jgraham
That's possibly a thing we can fix with a cross-origin communication primitive
-
jgraham
I mean it seems amazingly inefficient to go page -> server -> test page -> server -> perform command on test page but it would work
-
BitBot
(wpt) [PR] annevk merged #25558 by annevk into master: Check removal of allowPaymentRequest IDL attribute -
git.io/JUBB3
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25430 by chromium-wpt-export-bot into master: [blink][web_tests] document-write tests cleanup -
git.io/JUnCC
-
BitBot
(wpt) [PR] ziransun requested #25562 merge into master: [WIP] port a couple of css-grid test files to WPT -
git.io/JUBPm
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25563 merge into master: Modernize WPT: resource-timing and navigation-timing.https.html -
git.io/JUBPh
-
BitBot
(wpt) [PR] moz-wptsync-bot merged #25553 by moz-wptsync-bot into master: [Gecko
Bug 1651569] reduce required SNR to accept KissFFT ConvolverNode implementation -
git.io/JUBWa
-
BitBot
(wpt) [PR] moz-wptsync-bot merged #25548 by moz-wptsync-bot into master: [Gecko
Bug 444222] Reset window.name when the new document is cross-origin - tests -
git.io/JUBYT
-
smcgruer_[EST]
jgraham: Do we actually catch the invalid communication, or does it just go nowhere?
-
BitBot
(wpt) [PR] stephenmcgruer closed #25539 by stephenmcgruer: [TMP] Testing stability check for coop test -
git.io/JUBvG
-
BitBot
(wpt) [PR] stephenmcgruer reopened #25539 by stephenmcgruer: [TMP] Testing stability check for coop test -
git.io/JUBvG
-
jgraham
It will end up as an error because we call window.__wptrunner_message_queue.push and that won't be defined
-
smcgruer_[EST]
Ok, thats good at least
-
BitBot
(wpt) [PR] ziransun requested #25564 merge into master: Python3: Add missing prefix -
git.io/JUBD4
-
BitBot
(wpt) [PR] stephenmcgruer merged #25564 by stephenmcgruer into master: Python3: Add missing prefix -
git.io/JUBD4
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25565 merge into master: Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness" -
git.io/JUBy6
-
BitBot
(wpt) [PR] autofoolip requested #25566 merge into master: Update interfaces/html.idl -
git.io/JUBHr
-
BitBot
(wpt) [PR] stephenmcgruer requested #25567 merge into master: Reland "[webdriver] Close old windows at the end of each test as well as beginning" -
git.io/JUBQc
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25534 by chromium-wpt-export-bot into master: sensors: Stop using "reading" events to check if a sensor is suspended. -
git.io/JU47v
-
BitBot
(wpt) [PR] stephenmcgruer merged #25566 by stephenmcgruer into master: Update interfaces/html.idl -
git.io/JUBHr
-
gsnedders
smcgruer_[EST]: you don't have any quick way to find the Chromium issue for your expectations including assertion descriptions?
-
smcgruer_[EST]
You mean the fact that assertion messages changing cause us to flake?
-
smcgruer_[EST]
I should be able to find it quickly
-
smcgruer_[EST]
crbug.com/679742 I believe
-
gsnedders
smcgruer_[EST]: I couldn't find it quickly :(
-
smcgruer_[EST]
Comment #30 pivots to talking about assertion messages
-
smcgruer_[EST]
Originally it was about console logs, cause we used to include those too...
-
jgraham
smcgruer_[EST]: So close_after_done originally was supposed to be about running each test in a clean browsing context (i.e. new tab) vs navigating a single tab
-
jgraham
It wasn't really supposed to be about cleaning up other windows
-
smcgruer_[EST]
Ah, ok. I'm happy to use a new flag then
-
smcgruer_[EST]
"may_pause_after_test"
-
smcgruer_[EST]
Or if we want to be commanding: "close_windows_after_test"
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25565 by chromium-wpt-export-bot into master: Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness" -
git.io/JUBy6
-
jgraham
I'm not sure it actually works correctly anymore since the non-close-after-done mode never got used
-
smcgruer_[EST]
I mean, its not used in non-marionette so I'd happily rip it out ;)
-
jgraham
I think I'm pretty happy to rip it out and just act as if it's always true
-
jgraham
But it could make a reappearance if people are unhappy with perf.
-
BitBot
(wpt) [PR] foolip requested #25568 merge into master: Update interfaces/compression.idl and test -
git.io/JUBbP
-
BitBot
(wpt) [issue] zcorpan opened #25569: Testing plan for :dir() pseudo-class -
git.io/JUBby
-
gsnedders
-
jgraham
gsnedders: Argh, WebKit bugzilla is in a time warp
-
jgraham
But if that already got reviewed it can just land I think?
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25570 merge into master: Test that stopped transceivers don't prevent offer/answer -
git.io/JUBNa
-
jgraham
I mean, I'm not convinced about logging every non-200 response with an error message in the server logs
-
gsnedders
jgraham: I just want your opinion on it :P
-
gsnedders
We tend to only have an error message if something specific has happened, which means it's typically useful for debugging issues
-
jgraham
So actually, what is strerr
-
jgraham
Oh wait strerror
-
jgraham
So
-
jgraham
The actual practical impact here is that with a 404 we sometimes also print "no such file or directory"
-
jgraham
As an error in the log
-
gsnedders
jgraham: or something else
-
gsnedders
jgraham: if the OSError/IOError isn't caused by whichever error code causes that
-
jgraham
Right
-
gsnedders
arguably we might even want to return 500 and not 404 in those cases
-
jgraham
It seems kind of reasonable to request GET /missing and get a 404 without getting an error in the logs
-
jgraham
I'm kind of worried this could cause logspam in gecko CI where we auto-extract error messages and they're supposed to be actionable things
-
jgraham
Although we already downgrade error to warning so it doesn't actually fail jobs
-
jgraham
So I think I"d object less if we used 500+error and 404+(some lower log level)
-
jgraham
Or any !500 really
-
BitBot
(wpt) [issue] youennf opened #25571: Upstream Blink OscillatorNode tests -
git.io/JUBpa
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25546 by chromium-wpt-export-bot into master: Reland "New TextBreakIterator's default behavior breaks after space run" -
git.io/JUBk4
-
gsnedders
jgraham: comment that on the bug and I'll have a look at some point
-
BitBot
(wpt) [PR] stephenmcgruer closed #25556 by stephenmcgruer: Update interfaces/compression.idl -
git.io/JUBBU
-
BitBot
(wpt) [PR] stephenmcgruer merged #25568 by stephenmcgruer into master: Update interfaces/compression.idl and test -
git.io/JUBbP
-
BitBot
(wpt) [PR] stephenmcgruer merged #25517 by stephenmcgruer into master: Cleanup more cases of passing async function to `async_test` -
git.io/JU4IG
-
BitBot
(wpt) [PR] stephenmcgruer requested #25572 merge into master: Change async_test to promise_test in clear-window-name.https.html -
git.io/JUBjE
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25529 by chromium-wpt-export-bot into master: [css-flex] Slight refactor to how table flex items are handled -
git.io/JU4XQ
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25573 merge into master: [IntersectionObserver] Fix cross-origin check for honoring rootMargin -
git.io/JURez
-
BitBot
(wpt) [PR] Hexcles merged #25275 by Hexcles into master: Attempt to fix escaping in CSP tests -
git.io/JULeX
-
BitBot
(wpt) [PR] Hexcles closed #25141 by Hexcles: [WIP] Python 3: Decode HEX value back to single quote -
git.io/JJxTY
-
jgraham
gsnedders: Done
-
BitBot
(wpt) [issue] Hexcles closed #23539: xrWebGLLayer_framebuffer_scale.https.html depends on chromium-only stuff -
git.io/Jf8r1
-
BitBot
(wpt) [issue] Hexcles closed #16455: Tests rely on missing infrastructure -
git.io/fj3Qc
-
smcgruer_[EST]
For nothing other than arguable ergnomics, have we considered consolidating `test` and `promise_test` into a single API?
-
smcgruer_[EST]
(I have just been introduced to ava -
github.com/avajs/ava/blob/master/docs/01-writing-tests.md - and reading through their API and design choices is interesting)
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25574 merge into master: Don't allow legacy list item markers inside an NG subtree. -
git.io/JURIJ
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25575 merge into master: Custom layout needs to force NG layout for the subtree. -
git.io/JURIU
-
smcgruer_[EST]
I'm also considering doing some perf analysis on running promise_tests on parallel (in case anyone has done that before?). To be clear, I am aware that's a huge change in behavior and we almost definitely have tests that rely on our clearly documented serial behavior, but if there's a significant perf improvement there it would be interesting to debate.
-
smcgruer_[EST]
We have ~7k promise_tests today over ~2.2k files
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25523 by chromium-wpt-export-bot into master: [webnfc] Remove id, recordType, and mediaType from NDEFScanOptions. -
git.io/JU4B3
-
jgraham
Yeah I don't think we're going to be able to change it to run in parallel, but might be able to have a parallel mode. But of course that's not super-different to using async tests
-
BitBot
(wpt) [PR] stephenmcgruer closed #25540 by stephenmcgruer: Always pass --enable-chrome-logs for Chromedriver -
git.io/JUBvc
-
BitBot
(wpt) [PR] stephenmcgruer reopened #25540 by stephenmcgruer: Always pass --enable-chrome-logs for Chromedriver -
git.io/JUBvc
-
jgraham
The general proposition "testharness could have a better API" is uncontroversial, the question is always how to get there
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #25576 merge into master: [Gecko
Bug 1662703] Make appearance: button behave like auto. -
git.io/JURLD
-
smcgruer_[EST]
"I don't think we're going to be able to change it to run in parallel" <-- do you feel this because of the (likely) existence of (potentially many) tests that rely on the behavior today?
-
smcgruer_[EST]
Its different to using async tests in that the API isn't... so painful
-
smcgruer_[EST]
(Personal opinion)
-
smcgruer_[EST]
Ava's choice to hang assert functions off of the test is interesting - it lets you associate a lot more asynchronous work with the correct test, but it still can't capture everything (e.g. if your test just randomly throws during an async block)
-
smcgruer_[EST]
Ava's choice to hang assert functions off of the test is interesting - it lets you associate a lot more asynchronous work with the correct test, but it still can't capture everything (e.g. if your test just randomly throws during an asynchronous block of code)
-
smcgruer_[EST]
... wow, go me forgetting this is IRC not slack. Can't just up-arrow-correct-typo -_-
-
smcgruer_[EST]
Anyway, EOD here so heading off. FYI I plan to look at your testdriver CL tomorrow afternoon EST (if I stick to my schedule)
-
BitBot
(wpt) [PR] Hexcles merged #25512 by Hexcles into master: [COOP] access reporting: Add same-origin/cross-origin variant. -
git.io/JU8yc
-
BitBot
(wpt) [PR] Hexcles merged #25518 by Hexcles into master: [Document Policy] Isolate font-display wpt tests -
git.io/JU4m3
-
jgraham
Yeah, I think making large behaviour-changing modifications is very difficult. Even just gsnedders PR changing assert_true(x == y) into assert_equals(x, y) got pushback since it's a small sematic change. Trying to make a large semantic change is going to be much worse because you probably actually need to verify each case for correctness. I don't think it's a reasonable ask for reviewers.
-
BitBot
(wpt) [PR] moz-wptsync-bot merged #25576 by moz-wptsync-bot into master: [Gecko
Bug 1662703] Make appearance: button behave like auto. -
git.io/JURLD
-
jgraham
Also, in general, you can get away with a lot more in test harnesses aimed at application level code because you have way more scope to implement high-level abstractions. When you want to be able to test the details of the browser you need to be able to control things at a very low level
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25555 by chromium-wpt-export-bot into master: Add XR support to video.rVFC -
git.io/JUBlr
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25577 merge into master: Increase event wait time for isInputPending WPTs -
git.io/JURqX
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #25578 merge into master: [Gecko
Bug 1518999] Update ContentfulPaint algorithm to follow the spec -
git.io/JURmf
-
BitBot
(wpt) [PR] LanWei22 requested #25579 merge into master: Newwheelinputtest -
git.io/JURms
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25577 by chromium-wpt-export-bot into master: Increase event wait time for isInputPending WPTs -
git.io/JURqX