01:09:55 -BitBot- (wpt) [PR] autofoolip requested #25556 merge into master: Update interfaces/compression.idl - https://git.io/JUBBU 01:10:36 -BitBot- (wpt) [PR] autofoolip requested #25557 merge into master: Update interfaces/webxr-hand-input.idl - https://git.io/JUBBT 01:18:30 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25538 by chromium-wpt-export-bot into master: [WPT] Refactor credential-management to use test-only-api.js - https://git.io/JU4j8 01:22:47 -BitBot- (wpt) [PR] marcoscaceres requested #25558 merge into master: Check removal of allowPaymentRequest IDL attribute - https://git.io/JUBB3 03:27:40 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25554 by chromium-wpt-export-bot into master: Deny ElementInternals.shadowRoot for pre-created shadow roots - https://git.io/JUBle 04:59:51 -BitBot- (wpt) [PR] marcoscaceres requested #25559 merge into master: allowpaymentrequest was deprecated - https://git.io/JUBu7 05:11:13 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25528 by chromium-wpt-export-bot into master: Add test case for 3D Preserve with 3D Transform Operations - https://git.io/JU4KA 05:14:50 -BitBot- (wpt) [PR] marcoscaceres requested #25560 merge into master: Replace allowpaymentrequest attr with allow=payment - https://git.io/JUBz2 05:44:34 -BitBot- (wpt) [PR] foolip merged #25557 by foolip into master: Update interfaces/webxr-hand-input.idl - https://git.io/JUBBT 07:35:17 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25545 by chromium-wpt-export-bot into master: [mathml] Disable multicol for MathML layout - https://git.io/JUBkW 08:13:28 -BitBot- (wpt) [PR] youennf requested #25561 merge into master: WebKit export of https://bugs.webkit.org/show_bug.cgi?id=216266 - https://git.io/JUBrp 08:42:47 smcgruer_[EST]: It doesn't work because all the communication with wptrunner has to be via the webdriver-controlled test document 08:47:59 That's possibly a thing we can fix with a cross-origin communication primitive 08:49:46 I mean it seems amazingly inefficient to go page -> server -> test page -> server -> perform command on test page but it would work 09:08:12 -BitBot- (wpt) [PR] annevk merged #25558 by annevk into master: Check removal of allowPaymentRequest IDL attribute - https://git.io/JUBB3 09:47:00 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25430 by chromium-wpt-export-bot into master: [blink][web_tests] document-write tests cleanup - https://git.io/JUnCC 09:53:24 -BitBot- (wpt) [PR] ziransun requested #25562 merge into master: [WIP] port a couple of css-grid test files to WPT - https://git.io/JUBPm 10:15:23 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25563 merge into master: Modernize WPT: resource-timing and navigation-timing.https.html - https://git.io/JUBPh 10:33:07 -BitBot- (wpt) [PR] moz-wptsync-bot merged #25553 by moz-wptsync-bot into master: [Gecko Bug 1651569] reduce required SNR to accept KissFFT ConvolverNode implementation - https://git.io/JUBWa 10:33:57 -BitBot- (wpt) [PR] moz-wptsync-bot merged #25548 by moz-wptsync-bot into master: [Gecko Bug 444222] Reset window.name when the new document is cross-origin - tests - https://git.io/JUBYT 10:59:28 jgraham: Do we actually catch the invalid communication, or does it just go nowhere? 11:02:25 -BitBot- (wpt) [PR] stephenmcgruer closed #25539 by stephenmcgruer: [TMP] Testing stability check for coop test - https://git.io/JUBvG 11:02:28 -BitBot- (wpt) [PR] stephenmcgruer reopened #25539 by stephenmcgruer: [TMP] Testing stability check for coop test - https://git.io/JUBvG 11:12:37 It will end up as an error because we call window.__wptrunner_message_queue.push and that won't be defined 11:12:50 Ok, thats good at least 11:39:37 -BitBot- (wpt) [PR] ziransun requested #25564 merge into master: Python3: Add missing prefix - https://git.io/JUBD4 11:53:38 -BitBot- (wpt) [PR] stephenmcgruer merged #25564 by stephenmcgruer into master: Python3: Add missing prefix - https://git.io/JUBD4 12:02:20 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25565 merge into master: Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness" - https://git.io/JUBy6 12:41:57 -BitBot- (wpt) [PR] autofoolip requested #25566 merge into master: Update interfaces/html.idl - https://git.io/JUBHr 13:01:47 -BitBot- (wpt) [PR] stephenmcgruer requested #25567 merge into master: Reland "[webdriver] Close old windows at the end of each test as well as beginning" - https://git.io/JUBQc 13:26:06 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25534 by chromium-wpt-export-bot into master: sensors: Stop using "reading" events to check if a sensor is suspended. - https://git.io/JU47v 13:47:36 -BitBot- (wpt) [PR] stephenmcgruer merged #25566 by stephenmcgruer into master: Update interfaces/html.idl - https://git.io/JUBHr 13:59:45 smcgruer_[EST]: you don't have any quick way to find the Chromium issue for your expectations including assertion descriptions? 14:00:26 You mean the fact that assertion messages changing cause us to flake? 14:00:36 I should be able to find it quickly 14:01:34 crbug.com/679742 I believe 14:01:40 smcgruer_[EST]: I couldn't find it quickly :( 14:03:14 Comment #30 pivots to talking about assertion messages 14:03:24 Originally it was about console logs, cause we used to include those too... 14:04:37 smcgruer_[EST]: So close_after_done originally was supposed to be about running each test in a clean browsing context (i.e. new tab) vs navigating a single tab 14:04:53 It wasn't really supposed to be about cleaning up other windows 14:04:55 Ah, ok. I'm happy to use a new flag then 14:05:01 "may_pause_after_test" 14:05:10 Or if we want to be commanding: "close_windows_after_test" 14:05:26 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25565 by chromium-wpt-export-bot into master: Reland "[mathml] Use post.underlineThickness for the default fraction rulethickness" - https://git.io/JUBy6 14:05:35 I'm not sure it actually works correctly anymore since the non-close-after-done mode never got used 14:05:51 I mean, its not used in non-marionette so I'd happily rip it out ;) 14:06:32 I think I'm pretty happy to rip it out and just act as if it's always true 14:07:00 But it could make a reappearance if people are unhappy with perf. 14:48:11 -BitBot- (wpt) [PR] foolip requested #25568 merge into master: Update interfaces/compression.idl and test - https://git.io/JUBbP 14:51:16 -BitBot- (wpt) [issue] zcorpan opened #25569: Testing plan for :dir() pseudo-class - https://git.io/JUBby 14:58:28 jgraham: https://github.com/web-platform-tests/wpt/pull/25536 15:02:55 gsnedders: Argh, WebKit bugzilla is in a time warp 15:03:09 But if that already got reviewed it can just land I think? 15:03:10 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25570 merge into master: Test that stopped transceivers don't prevent offer/answer - https://git.io/JUBNa 15:04:02 I mean, I'm not convinced about logging every non-200 response with an error message in the server logs 15:07:27 jgraham: I just want your opinion on it :P 15:08:03 We tend to only have an error message if something specific has happened, which means it's typically useful for debugging issues 15:14:45 So actually, what is strerr 15:14:55 Oh wait strerror 15:15:12 So 15:15:35 The actual practical impact here is that with a 404 we sometimes also print "no such file or directory" 15:15:49 As an error in the log 15:16:15 jgraham: or something else 15:16:32 jgraham: if the OSError/IOError isn't caused by whichever error code causes that 15:16:41 Right 15:17:15 arguably we might even want to return 500 and not 404 in those cases 15:18:07 It seems kind of reasonable to request GET /missing and get a 404 without getting an error in the logs 15:18:40 I'm kind of worried this could cause logspam in gecko CI where we auto-extract error messages and they're supposed to be actionable things 15:18:59 Although we already downgrade error to warning so it doesn't actually fail jobs 15:19:53 So I think I"d object less if we used 500+error and 404+(some lower log level) 15:20:11 Or any !500 really 16:08:27 -BitBot- (wpt) [issue] youennf opened #25571: Upstream Blink OscillatorNode tests - https://git.io/JUBpa 16:10:44 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25546 by chromium-wpt-export-bot into master: Reland "New TextBreakIterator's default behavior breaks after space run" - https://git.io/JUBk4 16:13:02 jgraham: comment that on the bug and I'll have a look at some point 16:44:23 -BitBot- (wpt) [PR] stephenmcgruer closed #25556 by stephenmcgruer: Update interfaces/compression.idl - https://git.io/JUBBU 16:44:24 -BitBot- (wpt) [PR] stephenmcgruer merged #25568 by stephenmcgruer into master: Update interfaces/compression.idl and test - https://git.io/JUBbP 16:56:33 -BitBot- (wpt) [PR] stephenmcgruer merged #25517 by stephenmcgruer into master: Cleanup more cases of passing async function to `async_test` - https://git.io/JU4IG 17:00:58 -BitBot- (wpt) [PR] stephenmcgruer requested #25572 merge into master: Change async_test to promise_test in clear-window-name.https.html - https://git.io/JUBjE 17:19:33 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25529 by chromium-wpt-export-bot into master: [css-flex] Slight refactor to how table flex items are handled - https://git.io/JU4XQ 17:30:26 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25573 merge into master: [IntersectionObserver] Fix cross-origin check for honoring rootMargin - https://git.io/JURez 17:42:02 -BitBot- (wpt) [PR] Hexcles merged #25275 by Hexcles into master: Attempt to fix escaping in CSP tests - https://git.io/JULeX 17:42:26 -BitBot- (wpt) [PR] Hexcles closed #25141 by Hexcles: [WIP] Python 3: Decode HEX value back to single quote - https://git.io/JJxTY 17:51:56 gsnedders: Done 18:20:08 -BitBot- (wpt) [issue] Hexcles closed #23539: xrWebGLLayer_framebuffer_scale.https.html depends on chromium-only stuff - https://git.io/Jf8r1 19:11:28 -BitBot- (wpt) [issue] Hexcles closed #16455: Tests rely on missing infrastructure - https://git.io/fj3Qc 19:56:34 For nothing other than arguable ergnomics, have we considered consolidating `test` and `promise_test` into a single API? 19:57:08 (I have just been introduced to ava - https://github.com/avajs/ava/blob/master/docs/01-writing-tests.md - and reading through their API and design choices is interesting) 20:21:54 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25574 merge into master: Don't allow legacy list item markers inside an NG subtree. - https://git.io/JURIJ 20:22:29 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25575 merge into master: Custom layout needs to force NG layout for the subtree. - https://git.io/JURIU 20:23:31 I'm also considering doing some perf analysis on running promise_tests on parallel (in case anyone has done that before?). To be clear, I am aware that's a huge change in behavior and we almost definitely have tests that rely on our clearly documented serial behavior, but if there's a significant perf improvement there it would be interesting to debate. 20:23:40 We have ~7k promise_tests today over ~2.2k files 20:37:45 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25523 by chromium-wpt-export-bot into master: [webnfc] Remove id, recordType, and mediaType from NDEFScanOptions. - https://git.io/JU4B3 20:57:42 Yeah I don't think we're going to be able to change it to run in parallel, but might be able to have a parallel mode. But of course that's not super-different to using async tests 20:58:13 -BitBot- (wpt) [PR] stephenmcgruer closed #25540 by stephenmcgruer: Always pass --enable-chrome-logs for Chromedriver - https://git.io/JUBvc 20:58:16 -BitBot- (wpt) [PR] stephenmcgruer reopened #25540 by stephenmcgruer: Always pass --enable-chrome-logs for Chromedriver - https://git.io/JUBvc 20:59:31 The general proposition "testharness could have a better API" is uncontroversial, the question is always how to get there 20:59:53 -BitBot- (wpt) [PR] moz-wptsync-bot requested #25576 merge into master: [Gecko Bug 1662703] Make appearance: button behave like auto. - https://git.io/JURLD 21:06:41 "I don't think we're going to be able to change it to run in parallel" <-- do you feel this because of the (likely) existence of (potentially many) tests that rely on the behavior today? 21:06:50 Its different to using async tests in that the API isn't... so painful 21:06:56 (Personal opinion) 21:07:29 Ava's choice to hang assert functions off of the test is interesting - it lets you associate a lot more asynchronous work with the correct test, but it still can't capture everything (e.g. if your test just randomly throws during an async block) 21:07:36 Ava's choice to hang assert functions off of the test is interesting - it lets you associate a lot more asynchronous work with the correct test, but it still can't capture everything (e.g. if your test just randomly throws during an asynchronous block of code) 21:07:54 ... wow, go me forgetting this is IRC not slack. Can't just up-arrow-correct-typo -_- 21:08:52 Anyway, EOD here so heading off. FYI I plan to look at your testdriver CL tomorrow afternoon EST (if I stick to my schedule) 21:11:35 -BitBot- (wpt) [PR] Hexcles merged #25512 by Hexcles into master: [COOP] access reporting: Add same-origin/cross-origin variant. - https://git.io/JU8yc 21:13:53 -BitBot- (wpt) [PR] Hexcles merged #25518 by Hexcles into master: [Document Policy] Isolate font-display wpt tests - https://git.io/JU4m3 21:23:43 Yeah, I think making large behaviour-changing modifications is very difficult. Even just gsnedders PR changing assert_true(x == y) into assert_equals(x, y) got pushback since it's a small sematic change. Trying to make a large semantic change is going to be much worse because you probably actually need to verify each case for correctness. I don't think it's a reasonable ask for reviewers. 21:26:45 -BitBot- (wpt) [PR] moz-wptsync-bot merged #25576 by moz-wptsync-bot into master: [Gecko Bug 1662703] Make appearance: button behave like auto. - https://git.io/JURLD 21:29:56 Also, in general, you can get away with a lot more in test harnesses aimed at application level code because you have way more scope to implement high-level abstractions. When you want to be able to test the details of the browser you need to be able to control things at a very low level 21:52:55 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25555 by chromium-wpt-export-bot into master: Add XR support to video.rVFC - https://git.io/JUBlr 22:03:01 -BitBot- (wpt) [PR] chromium-wpt-export-bot requested #25577 merge into master: Increase event wait time for isInputPending WPTs - https://git.io/JURqX 22:25:23 -BitBot- (wpt) [PR] moz-wptsync-bot requested #25578 merge into master: [Gecko Bug 1518999] Update ContentfulPaint algorithm to follow the spec - https://git.io/JURmf 22:44:31 -BitBot- (wpt) [PR] LanWei22 requested #25579 merge into master: Newwheelinputtest - https://git.io/JURms 23:29:27 -BitBot- (wpt) [PR] chromium-wpt-export-bot merged #25577 by chromium-wpt-export-bot into master: Increase event wait time for isInputPending WPTs - https://git.io/JURqX