-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25580 merge into master: Fieldset NG: Fix hit-testing for the rendered LEGEND, take 2 -
git.io/JUR3M
-
BitBot
(wpt) [PR] autofoolip requested #25581 merge into master: Update interfaces/webauthn.idl -
git.io/JUR3S
-
BitBot
(wpt) [PR] autofoolip requested #25582 merge into master: Update interfaces/webxr-hand-input.idl -
git.io/JUR39
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #25583 merge into master: [Gecko
Bug 1646601] test AudioContext constructor throws when not fully active -
git.io/JURsC
-
BitBot
(wpt) [PR] yutakahirano requested #25584 merge into master: Fix html/coep/cross-origin-isolated-permission.https.html -
git.io/JURGv
-
BitBot
(wpt) [PR] twilco requested #25585 merge into master: Remove hanging script tag in font-parse-numeric-stretch-style-weight.html -
git.io/JURG1
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25586 merge into master: [WPT] Add module version of service-worker/registration-script.https.html -
git.io/JURnX
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25587 merge into master: FontAccess: Sticky User Activation is required to enumerate -
git.io/JURlf
-
BitBot
(wpt) [PR] autofoolip requested #25588 merge into master: Update interfaces/cookie-store.idl -
git.io/JURlg
-
BitBot
(wpt) [PR] jfkthame merged #25585 by jfkthame into master: Remove hanging script tag in font-parse-numeric-stretch-style-weight.html -
git.io/JURG1
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25574 by chromium-wpt-export-bot into master: Don't allow legacy list item markers inside an NG subtree. -
git.io/JURIJ
-
BitBot
(wpt) [PR] foolip merged #25588 by foolip into master: Update interfaces/cookie-store.idl -
git.io/JURlg
-
BitBot
(wpt) [PR] foolip merged #25581 by foolip into master: Update interfaces/webauthn.idl -
git.io/JUR3S
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25570 by chromium-wpt-export-bot into master: Test that stopped transceivers don't prevent offer/answer -
git.io/JUBNa
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25580 by chromium-wpt-export-bot into master: Fieldset NG: Fix hit-testing for the rendered LEGEND, take 2 -
git.io/JUR3M
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25589 merge into master: wpt: add pointer about webrtc/h264 failures on buildbots -
git.io/JURzv
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25451 by chromium-wpt-export-bot into master: Splitting the insertable-stream test file into multiple test files -
git.io/JUcgY
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25590 merge into master: [mathml] Only perform special handling of <mo>s when they are text-only -
git.io/JURgw
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #25591 merge into master: [Gecko
Bug 1658702] part 13: Add WPT for `getTargetRanges()` for non-collapsed selection -
git.io/JURgH
-
BitBot
(wpt) [PR] ziransun requested #25592 merge into master: Python3: Read file into a byte string -
git.io/JUR20
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25593 merge into master: [LayoutNG] Fix ScrollableOverflowForPropagation() -
git.io/JURau
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #25594 merge into master: [Gecko
Bug 1493108] [wdspec] Improve tests for browsing context checks. -
git.io/JURV8
-
zcorpan
smcgruer_[EST]: MikeSmith:
wpt.live has files in the root level that shouldn't be there (again?)
-
smcgruer_[EST]
Interesting, looks like it's there on
w3c-test.org too
-
smcgruer_[EST]
Seems like a lot of them (after-*, before-*, segment-*, text-*, ...)
-
zcorpan
might be a bug in the PR mirror feature, I think it's been a problem on w3c-test.org for years
-
smcgruer_[EST]
Been there for a while; looks like they came into existence around September 3rd (or at least one set did).
-
smcgruer_[EST]
Is there any overlap in the mechanisms for w3c-test.org and wpt.live?
-
smcgruer_[EST]
(I tell a lie, September 4th around 4:30am EST for conformance-checkers/html-svg/types-dom-08-f-isvalid.html)
-
smcgruer_[EST]
*6:25am EST
-
smcgruer_[EST]
Heh, I can take a guess
-
smcgruer_[EST]
DEBUG:web-platform-tests:GET /24556/conformance-checkers/tools/build-svg-tests.py
-
smcgruer_[EST]
Want to bet that causes the script to run as a python file handler and builds the tests?
-
smcgruer_[EST]
Hrm, then again it doesnt have a main() that fits the shape for wptserve...
-
smcgruer_[EST]
... but it runs it unconditionally -_-
-
smcgruer_[EST]
(there's no __name__ guard)
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25595 merge into master: [Sanitizer API] Make a copy of wpt tests to the internal one -
git.io/JURof
-
smcgruer_[EST]
Hrm, doing that locally with wptserve doesn't work however :/
-
smcgruer_[EST]
And something like mimesniff/mime-types/resources/generated-mime-types.py also doesn't have a guard ... oh, and looks like we have 'generated-mime-types.json' in the root as well
-
smcgruer_[EST]
Hrm, maybe I'm down a red herring here, conformance-checkers/tools/build-svg-tests.py has existed forever :/
-
smcgruer_[EST]
Although maybe it was just that on Sept 4th, someone hit that URL
-
smcgruer_[EST]
Ok so yeah, just visiting wpt.live/conformance-checkers/tools/build-svg-tests.py doesnt seem to trigger it (it just 404s)
-
smcgruer_[EST]
I've cleaned wpt.live, looking at wptpr.live now
-
smcgruer_[EST]
No unexpected files on wptpr.live, everything should be clean (albeit the root cause is still a mystery)
-
smcgruer_[EST]
To summarize: my earlier investigations into conformance-checkers was bunk, those aren't even the unexpected files. I blame morning-brain.
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25596 merge into master: [COOP] Access reporting with 2 reporters. -
git.io/JURKV
-
jgraham
UNrelated random drain dump: I've seen several requests for better auditing of tests e.g. whatever audit.js is and various things from gecko developers. We already record which steps run but don't use that information anywhere. We could also associate asserts with tests/steps by keeping an explicit stack of tests on the tests object i.e. we push to the stack immediately before invoking the callback
-
jgraham
function in Test.step() and pop from the stack after it completes. Then the current test/step is the last thing on that stack. So in all the assert_* functions we could create an assert object with details about the assert and update it with the pass/fail in assert() itself. Then we expose this somehow e.g. if you click on a test result in the log view it uses this data to reconstruct a log of all the
-
jgraham
things that ran
-
jgraham
This should be lazy to avoid creating even more DOM on the tests with 10,000 subtests
-
smcgruer_[EST]
Modulo the usual 'things go weird if developers fail to t.step()' , SGTM
-
smcgruer_[EST]
I'd love some more input as to what details they feel they want
-
BitBot
(wpt) [PR] yutakahirano requested #25597 merge into master: Check document.domain mutation with cross-origin isolated -
git.io/JUR6Y
-
jgraham
I think sometimes it's hard to even understand what stages the test went through before it failed.
-
jgraham
Seeing which asserts actually passed could help there
-
smcgruer_[EST]
Ah yeah, that'd be quite neat
-
smcgruer_[EST]
This test hit [these asserts], but then hit [this assert] which failed is a cool idea
-
jgraham
I don't think it's that hard to implement, although getting the output to be nice is probably some work
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25598 merge into master: Treat NG objects inside legacy fragmentation as monolithic. -
git.io/JURPf
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25563 by chromium-wpt-export-bot into master: Modernize WPT: resource-timing and navigation-timing.https.html -
git.io/JUBPh
-
gsnedders
"22:23 < jgraham> Yeah, I think making large behaviour-changing modifications is very difficult"
-
gsnedders
jgraham: what's that in response to?
-
gsnedders
oh wait in response to smcgruer_[EST]
-
gsnedders
also: once we're running using Python 3, should we move to using the venv in stdlib, despite it being much more limited than virtualenv?
-
BitBot
(wpt) [PR] zcorpan requested #25599 merge into master: HTML: Add test for <input type=tel> matching :dir() -
git.io/JURXe
-
BitBot
(wpt) [PR] moz-wptsync-bot merged #25583 by moz-wptsync-bot into master: [Gecko
Bug 1646601] test AudioContext constructor throws when not fully active -
git.io/JURsC
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25589 by chromium-wpt-export-bot into master: wpt: add pointer about webrtc/h264 failures on buildbots -
git.io/JURzv
-
zcorpan
jgraham: annevk: when adding a new test that fails in firefox, a bug is filed automatically, right? is there any need to file a bug manually?
-
BitBot
(wpt) [PR] moz-wptsync-bot requested #25600 merge into master: [Gecko
Bug 1665402] fix SVGGeometry.getTotalLength to work if the element is not attached to the document or is display:none -
git.io/JUR1S
-
BitBot
(wpt) [PR] jgraham merged #25594 by jgraham into master: [Gecko
Bug 1493108] [wdspec] Improve tests for browsing context checks. -
git.io/JURV8
-
BitBot
(wpt) [PR] domenic merged #25310 by domenic into master: HTML: make sure the default opacity of ::placeholder is 1 -
git.io/JUmtu
-
jgraham
zcorpan: It's filed automatically for some components
-
jgraham
If it's a layout or DOM bug it should just work
-
zcorpan
jgraham: ok, thanks. I'm making a presentation about writing tests, and am at the step to file a browser bug :) I guess I'll mention that for some tests, a bug is created automatically, but show how to file a bug anyway
-
jgraham
Yeah, the system isn't flawless yet, so teaching people to do it manually is still very good
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25601 merge into master: Prevent break opportunity offset to surpass the item's range_end -
git.io/JURDX
-
BitBot
(wpt) [PR] youennf merged #25493 by youennf into master: Feature/media capture fitness distance -
git.io/JUW9m
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25602 merge into master: [Sanitizer API] Add blockAttributes to SanitizerConfig. -
git.io/JURy5
-
gsnedders
jgraham: should I rewrite an RFC for the != -> !== change?
-
gsnedders
I mean the problem is assert_true(x != null) isn't the same as assert_not_equals(x, null) given x = undefined differs
-
gsnedders
and I guess the same is arguably true for "1" and 1 for example
-
gsnedders
i.e., people are okay with refining pass conditions but not making them broader?
-
gsnedders
which to be fair is a reasonable objection
-
jgraham
I don't think it needs an RFC
-
jgraham
Like there's no policy change here or anything
-
jgraham
It needs someone to verify that the change makes sense in the context of the tests
-
jgraham
(assert_not_equals is always a construct of last resort, so the ideal change would be replacing the negative assert with a positive one)
-
gsnedders
I'd be sad not to land that PR, but I also don't really have the energy to fight for it
-
smcgruer_[EST]
Would you be willing to land the less controversial parts? (I know that will take some rework)
-
BitBot
(wpt) [PR] Loirooriol merged #25342 by Loirooriol into master: Adds typed-om flow relative border tests -
git.io/JUYkx
-
gsnedders
which is… everything that doesn't touch convert to assert_not_equals, right?
-
gsnedders
even x !== y -> assert_not_equals(x, y) is technically less strict
-
smcgruer_[EST]
I think there wasn't much concern about x !== y to assert_not_equals(x, y), was there? The 'big' uproar was over != ?
-
gsnedders
!== is still technically unsafe, but yeah, the "big" concern was !=
-
smcgruer_[EST]
Yeah, so I think !== alone would be great :)
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25552 by chromium-wpt-export-bot into master: Add tentative WPT for Schemeful Same-Site -
git.io/JUBC9
-
jgraham
Just got (another) request to use testdriver with cross-process iframes
-
jgraham
Which my PR doesn't solve
-
gsnedders
is there any way we can reasonably allow that? I guess if we somehow do something with postmessage?
-
gsnedders
wait didn't someone write a prototype along those lines?
-
jgraham
I don't know someone wrote a prototype, but there are a couple of options
-
jgraham
postMessage works for basic cross-origin, but falls down for rel=noopener
-
jgraham
We can also build something on the server side where you send the message to the server and it handles things
-
jgraham
But maybe the the normal cross-origin case isn't too hard
-
jgraham
We already have a message event handler
-
jgraham
Just make that forward the argument to the testdriver event loop and arrange to postMessage something in return when there's a response
-
gsnedders
blimin' heck, orjson is fast to serialize
-
gsnedders
whatever has changed since I benchmarked this before, but ujson/orjson are well worth it for serializing
-
jgraham
This thing where all the frames need to cooperate to make sure only one is calling testdriver at the same time is exciting
-
jgraham
Not sure why each command doesn't get an id and we could key the resolve/reject promise on that
-
jgraham
rather than just having one
-
gsnedders
so I think we should readd support for ujson?
-
jgraham
Sure
-
smcgruer_[EST]
Hah, I was just reviewing this
-
smcgruer_[EST]
(Then lost all my comments, thanks GitHub - and thanks Stephen for not reading prompts and just clicking 'ok go away')
-
smcgruer_[EST]
But yeah, I was going to suggest something with postMessage
-
smcgruer_[EST]
Basically 'whats my unique window id' 'here you go' 'ok now I can call testdriver with that id'
-
smcgruer_[EST]
Or... what jgraham said
-
smcgruer_[EST]
Ok, now to retype all my reviews
-
smcgruer_[EST]
s/reviews/comments
-
jgraham
You mean instead of abusing window.name?
-
jgraham
I think you still need most of the stuff in that PR because it's mostly about working around the lack of support for targetting a specific browsing context in webdriver given a pointer to that context
-
gsnedders
jgraham: how do you feel about install ujson with wptrunner?
-
jgraham
gsnedders: That potentially has vendor integration consequences
-
jgraham
I certainly don't mind doing it when wpt run is invoked
-
jgraham
I'm less sure about putting it in the requirements.txt
-
jgraham
(basically: I don't expect we hae it available in gecko CI so I don't want it to end up trying to install it there)
-
smcgruer_[EST]
jgraham: I was thinking just to let testdriver work in cross-origin iframes, by letting it ask the main frame for the window name and then calling testdriver directly. However I think I had the wrong mental model and you're right that we would need to proxy via the original/main frame.
-
jgraham
Right, if we wanted that to work we'd need the other frame to communicate somehow that webdriver should stop listening to the main frame and do something in another frame for a bit
-
jgraham
That's basically the design for rel=noopener
-
jgraham
But it's much more work because it kind of changes the whole model
-
gsnedders
oh gosh we have a variable called "stack" that we use as a FILO queue ;_;
-
jgraham
You have to have some way for a websocket or similar to interrupt the wptrunner event loop
-
jgraham
Which is probably exciting
-
smcgruer_[EST]
Too exciting for my blood
-
smcgruer_[EST]
I like the idea of proxying testdriver, I guess you just need to pass the main window your selector and it can do the rest?
-
jgraham
(this is where webdriver bidi immediately solves all our problems by not requiring blocking communication with a single frame)
-
smcgruer_[EST]
So how's that webdriver bidi stuff going? ;)
-
jgraham
I mean more slowly because I'm talking about this instead :p
-
jgraham
(also, today, because our sync seems to have developed a serious bug that I fully blame on Python 3 but don't yet understand)
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25603 merge into master: [LayoutShiftTracker] Fix contain:paint -
git.io/JU0eI
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25601 by chromium-wpt-export-bot into master: Prevent break opportunity offset to surpass the item's range_end -
git.io/JURDX
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25399 by chromium-wpt-export-bot into master: idle-detection: Implement requestPermission() method -
git.io/JU3CI
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25604 merge into master: Add tests to validate XR compatible request scenarios that should throw -
git.io/JU0fe
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25605 merge into master: Add new fontBoundingBoxAscent/Descent test -
git.io/JU0UJ
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25603 by chromium-wpt-export-bot into master: [LayoutShiftTracker] Fix contain:paint -
git.io/JU0eI
-
BitBot
(wpt) [PR] TalbotG requested #25606 merge into master: Made active-selection-031-ref.html more precise -
git.io/JU0kf
-
BitBot
(wpt) [PR] chromium-wpt-export-bot merged #25590 by chromium-wpt-export-bot into master: [mathml] Only perform special handling of <mo>s when they are text-only -
git.io/JURgw
-
BitBot
(wpt) [PR] TalbotG requested #25607 merge into master: Corrected (more precise) comments in the 3rd ascii drawing -
git.io/JU0kW
-
BitBot
(wpt) [PR] chromium-wpt-export-bot requested #25608 merge into master: Fix clear-window-name.https.html fail message -
git.io/JU0kR